Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add developer instructions #57

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Oct 11, 2023

Add documentation that describes how to update the code, build a new image
and test the code changes in a ModelMesh Serving deployment.

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner requested review from rafvasq and removed request for joerunde and njhill October 11, 2023 21:35
@ckadner ckadner added the documentation Improvements or additions to documentation label Oct 11, 2023
Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @ckadner. Just the one update for me.

README.md Outdated Show resolved Hide resolved
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner requested a review from rafvasq October 12, 2023 16:43
Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit ad03d9a into kserve:main Oct 12, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved documentation Improvements or additions to documentation lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants