Skip to content

Commit

Permalink
enclose commit short hash in quotes
Browse files Browse the repository at this point in the history
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
  • Loading branch information
ckadner committed Jan 9, 2024
1 parent 20d00fc commit 349274e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/fvt-base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,15 @@ jobs:
- name: Set controller image tag
run: |
# TODO: remove this next line and reinstate the original line after that
echo "IMAGE_TAG=7284872" >> $GITHUB_ENV
# echo "IMAGE_TAG=$(date +'%Y%m%dT%H%M%S%Z')" >> $GITHUB_ENV
echo "IMAGE_TAG=$(date +'%Y%m%dT%H%M%S%Z')" >> $GITHUB_ENV
- name: Update configs
# Update the image tag and reduce some resource request amounts to allow FVTs to run
# on reduced resource environments. The RollingUpdate strategy for Runtime deployments
# is also adjusted for these environments.
# Disable the torchserve ServingRuntime for now (insufficient resources to run them all).
run: |
sed -i 's/newTag:.*$/newTag: '"${{ env.IMAGE_TAG }}"'/' config/manager/kustomization.yaml
sed -i 's/newTag:.*$/newTag: "'${{ env.IMAGE_TAG }}'"/' config/manager/kustomization.yaml
sed -i '0,/cpu:.*$/s/cpu:.*$/cpu: 100m/' \
config/default/config-defaults.yaml \
config/runtimes/mlserver-1.x.yaml \
Expand Down
3 changes: 2 additions & 1 deletion scripts/deploy/iks/deploy-mm-serving.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ curl -s "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack
mv kustomize /usr/local/bin/kustomize

# Update target tag and namespace/organization
sed -i.bak 's/newTag:.*$/newTag: '"$GIT_COMMIT_SHORT"'/' config/manager/kustomization.yaml
# enclose commit short hash in quotes to avoid it being interpreted as an int
sed -i.bak 's/newTag:.*$/newTag: "'${GIT_COMMIT_SHORT}'"/' config/manager/kustomization.yaml
sed -i.bak 's/newName:.*$/newName: '"$DOCKERSANDBOX_NAMESPACE\/modelmesh-controller"'/' config/manager/kustomization.yaml
rm config/manager/kustomization.yaml.bak

Expand Down

0 comments on commit 349274e

Please sign in to comment.