changed default_bucket to bucket

Signed-off-by: Aayush Subramaniam <aayushsubramaniam@gmail.com>
kserve · May 28, 2024 · 709c1af · 709c1af
1 parent 028f646
commit 709c1af
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/config/default/storage-secret.yaml b/config/default/storage-secret.yaml
@@ -27,5 +27,5 @@ metadata:
 #       "secret_access_key": "abcdff6a11223344aabbcc66ee231e6dd0c1122ff1234567",
 #       "endpoint_url": "https://s3.us-south.cloud-object-storage.appdomain.cloud",
 #       "region": "us-south",
-#       "default_bucket": "modelmesh-example-public"
+#       "bucket": "modelmesh-example-public"
 #     }
diff --git a/config/dependencies/fvt.yaml b/config/dependencies/fvt.yaml
@@ -122,7 +122,7 @@ stringData:
       "access_key_id": "AKIAIOSFODNN7EXAMPLE",
       "secret_access_key": "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
       "endpoint_url": "http://minio:9000",
-      "default_bucket": "modelmesh-example-models",
+      "bucket": "modelmesh-example-models",
       "region": "us-south"
     }
 ---

diff --git a/config/dependencies/minio-storage-secret.yaml b/config/dependencies/minio-storage-secret.yaml
@@ -22,6 +22,6 @@ stringData:
       "access_key_id": "AKIAIOSFODNN7EXAMPLE",
       "secret_access_key": "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
       "endpoint_url": "http://minio.controller_namespace:9000",
-      "default_bucket": "modelmesh-example-models",
+      "bucket": "modelmesh-example-models",
       "region": "us-south"
     }
diff --git a/config/dependencies/quickstart.yaml b/config/dependencies/quickstart.yaml
@@ -124,6 +124,6 @@ stringData:
       "access_key_id": "AKIAIOSFODNN7EXAMPLE",
       "secret_access_key": "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
       "endpoint_url": "http://minio:9000",
-      "default_bucket": "modelmesh-example-models",
+      "bucket": "modelmesh-example-models",
       "region": "us-south"
     }
diff --git a/docs/predictors/README.md b/docs/predictors/README.md
@@ -28,7 +28,7 @@ There should be secret key called `localMinIO` that looks like:
   "access_key": "AKIAIOSFODNN7EXAMPLE",
   "secret_access_key": "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
   "endpoint_url": "http://minio:9000",
-  "default_bucket": "modelmesh-example-models"
+  "bucket": "modelmesh-example-models"
 }
 ```
 

diff --git a/docs/predictors/setup-storage.md b/docs/predictors/setup-storage.md
@@ -60,7 +60,7 @@ $ mc ls myminio/models/onnx
 
 ### 3. Add a storage entry to the `storage-config` secret
 
-Ensure there is a key defined in the common `storage-config` secret corresponding to the S3-based storage instance holding your model. The value of this secret key should be JSON like the following, `default_bucket` is optional.
+Ensure there is a key defined in the common `storage-config` secret corresponding to the S3-based storage instance holding your model. The value of this secret key should be JSON like the following, `bucket` is optional.
 
 Users can specify use of a custom certificate via the storage config `certificate` parameter. The custom certificate should be in the form of an embedded Certificate Authority (CA) bundle in PEM format.
 
@@ -72,7 +72,7 @@ Using MinIO the JSON contents look like:
   "access_key_id": "minioadmin",
   "secret_access_key": "minioadmin/K7JTCMP/EXAMPLEKEY",
   "endpoint_url": "http://127.0.0.1:9000:9000",
-  "default_bucket": "",
+  "bucket": "",
   "region": "us-east"
 }
 ```
@@ -207,7 +207,7 @@ stringData:
 #      "access_key_id": "AKIAIOSFODNN7EXAMPLE",
 #      "secret_access_key": "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
 #      "endpoint_url": "http://minio:9000",
-#      "default_bucket": "modelmesh-example-models",
+#      "bucket": "modelmesh-example-models",
 #      "region": "us-south"
 #    }
   pvc1: |

diff --git a/fvt/globals.go b/fvt/globals.go
@@ -46,7 +46,7 @@ var StorageConfigDataMinio = map[string]interface{}{
 		"access_key_id":     "AKIAIOSFODNN7EXAMPLE",
 		"secret_access_key": "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
 		"endpoint_url":      "http://minio:9000",
-		"default_bucket":    "modelmesh-example-models",
+		"bucket":    "modelmesh-example-models",
 		"region":            "us-south",
 	},
 }