Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated API version for HPA #402

Closed
rafvasq opened this issue Jul 18, 2023 · 0 comments · Fixed by #403
Closed

Update deprecated API version for HPA #402

rafvasq opened this issue Jul 18, 2023 · 0 comments · Fixed by #403
Assignees
@rafvasq
Labels
enhancement New feature or request
Milestone
v0.11.0

Comments

@rafvasq
Copy link
Member

rafvasq commented Jul 18, 2023 •
edited by ckadner
Loading

As per #374, OpenShift v4.13 and K8s v1.26 don't include beta2 version of HPA:

W0713 21:57:33.276930       1 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler

Need to update minimum supported Kubernetes version to 1.23:

Originally posted by @ckadner in #374 (comment)
@rafvasq rafvasq changed the title Update the Go for the latest Kubernetes version Update Go for the latest Kubernetes version Jul 18, 2023
@rafvasq rafvasq mentioned this issue Jul 19, 2023
Merged
@rafvasq rafvasq self-assigned this Jul 19, 2023
@rafvasq rafvasq added the enhancement New feature or request label Jul 19, 2023
@rafvasq rafvasq added this to the v0.11.0 milestone Jul 19, 2023
@rafvasq rafvasq changed the title Update Go for the latest Kubernetes version Update deprecated api version for HPA Jul 19, 2023
@rafvasq rafvasq changed the title Update deprecated api version for HPA Update deprecated API version for HPA Jul 19, 2023
@rafvasq rafvasq mentioned this issue Jul 19, 2023
Merged
@ckadner ckadner moved this to In Progress in KServe 0.11 Jul 19, 2023
ckadner added a commit that referenced this issue Jul 20, 2023
@rafvasq @ckadner
chore: Upgrade to use autoscaling/v2 for HPA (#403)
ef26b75 
The 'autoscaling/v2beta2' API for HPA was deprecated in Kubernetes version 1.23
and is no longer available in Kubernetes version 1.26.

Changes:
- Update Go code to use 'autoscaling/v2'
- Use setup-envtest to force K8s v1.23+ for unit tests to ensure
  the 'autoscaling/v2' API is available
- Update FVT to use Kubernetes version 1.26+

Closes #402

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Co-authored-by: Christian Kadner <ckadner@us.ibm.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in KServe 0.11 Jul 20, 2023
ckadner pushed a commit that referenced this issue Jul 24, 2023
@rafvasq
chore: Upgrade to use autoscaling/v2 for HPA (#403)
b180773 
The 'autoscaling/v2beta2' API for HPA was deprecated in Kubernetes version 1.23
and is no longer available in Kubernetes version 1.26.

Changes:
- Update Go code to use 'autoscaling/v2'
- Use setup-envtest to force K8s v1.23+ for unit tests to ensure
  the 'autoscaling/v2' API is available
- Update FVT to use Kubernetes version 1.26+

Closes #402

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Co-authored-by: Christian Kadner <ckadner@us.ibm.com>
(cherry picked from commit ef26b75)
ckadner pushed a commit that referenced this issue Jul 24, 2023
@rafvasq
chore: Upgrade to use autoscaling/v2 for HPA (#403)
b8d697d 
The 'autoscaling/v2beta2' API for HPA was deprecated in Kubernetes version 1.23
and is no longer available in Kubernetes version 1.26.

Changes:
- Update Go code to use 'autoscaling/v2'
- Use setup-envtest to force K8s v1.23+ for unit tests to ensure
  the 'autoscaling/v2' API is available
- Update FVT to use Kubernetes version 1.26+

Closes #402

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Co-authored-by: Christian Kadner <ckadner@us.ibm.com>
(cherry picked from commit ef26b75)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafvasq rafvasq

Labels
enhancement New feature or request
Projects
No open projects
KServe 0.11
Status: Done
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

chore: Bump to use autoscaling/v2 rafvasq/modelmesh-serving
1 participant
@rafvasq