Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release Doc #408

Open
1 of 2 tasks
rafvasq opened this issue Jul 25, 2023 · 2 comments
Open
1 of 2 tasks

Update Release Doc #408

rafvasq opened this issue Jul 25, 2023 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@rafvasq
Copy link
Member

rafvasq commented Jul 25, 2023

Update the release doc to include instructions for the following:

Originally posted by @ckadner in #406 (comment)

@rafvasq rafvasq added the documentation Improvements or additions to documentation label Jul 25, 2023
@ckadner ckadner self-assigned this Jul 25, 2023
@ckadner
Copy link
Member

ckadner commented Jul 27, 2023

A few quick notes:

  • set the the git committer to "GitHub" before doing any cherry-picking or re-basing:
    export GIT_COMMITTER_NAME="GitHub"
    export GIT_COMMITTER_EMAIL="noreply@github.com"
    
  • do cherry-pick any new commits from main onto the release-* when creating new release candidates (rc1, rc2, ...) on the modelmesh-serving repo (only). Use the -x option to append the commit messages with the line "(cherry picked
    from commit …)":
    git checkout release-0.11
    git cherry-pick -x ..main
    git push
    
  • for the other repos (modelmesh, modelmesh-runtime-adapter, ...), if there are no divergent commits on the release-* branch, use git rebase from master
    git checkout release-0.11
    git rebase main
    git push
    
  • don't rebase the release-* branches after a ...-rc0 tag had been created, it would remove the commit that was used for the previous rc tag

ckadner added a commit to ckadner/modelmesh-serving that referenced this issue Aug 1, 2023
Related kserve#408

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Copy link
Member

ckadner commented Aug 2, 2023

We should also add a bit of text to describe the chicken-and-egg problem with kserve/kserve requiring the new ModelMesh release before creating it's new release (kserve/kserve#3059), but modelmesh-serving depending on the new KServe release so that it can create a new release (#413).

On the kserve/kserve side, the requirement is for the tagged Docker images to be available. To get those ModelMesh images before ModelMesh creates a new tagged release, the existing RC images can be retagged, assuming there were no (major) code changes since the last release candidate.

old_tag="v0.11.0-rc1"
new_tag="v0.11.0"

images=(
   modelmesh
   modelmesh-controller
   modelmesh-minio-dev-examples
   modelmesh-minio-examples
   modelmesh-runtime-adapter
   rest-proxy
)

for img in ${images[*]}; do
  # use `buildx imagetools` instead of `docker manifest` to maintain multi-arch manifests
  docker buildx imagetools create \
    "kserve/${img}:${old_tag}" --tag \
    "kserve/${img}:${new_tag}";
done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants