Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Remove cert flag from quickstart #364

Merged
merged 1 commit into from
May 9, 2023
Merged

doc: Remove cert flag from quickstart #364

merged 1 commit into from
May 9, 2023

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented May 4, 2023 •
edited by ckadner
Loading

Motivation

The quickstart instructions explicitly install the latest release v0.10 which does not include the recently added --enable-self-signed-ca or require info regarding webhook certificates. Following the document as-is results in an Unknown option error.

Modifications

  • Remove the --enable-self-signed-ca option from the quickstart guide and webhook information.

Result

  • Quickstart guide is functional for quick installation and deployment using the latest release v0.10

Resolves #370

@rafvasq rafvasq added bug Something isn't working documentation Improvements or additions to documentation labels May 4, 2023
@rafvasq rafvasq requested review from Jooho and ckadner May 4, 2023 13:41
@ckadner ckadner mentioned this pull request May 4, 2023
Closed
5 tasks
@ckadner
Copy link
Member

ckadner commented May 4, 2023

Good catch @rafvasq

I added a TODO in the release v0.11.0 checklist to reinstate it immediately after the v0.11.0 release.

Beyond this PR, we need to figure out a better way to handle these cross-version changes, like adding a note with a link at the top of the Quickstart Guide (and other install docs) to go the last release version of the document.

We had this problem several times before when we updated the Quickstart Guide for the kustomize version compatibility, ClusterServingRuntime, and namespace-scope mode.

ckadner
ckadner approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ckadner ckadner assigned tjohnson31415 and unassigned ckadner May 4, 2023
@ckadner ckadner mentioned this pull request May 5, 2023
Closed
@rafvasq @ckadner
doc: rm cert flag from quickstart
542115f 
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@kserve-oss-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ckadner, rafvasq
To complete the pull request process, please ask for approval from tjohnson31415 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner linked an issue May 9, 2023 that may be closed by this pull request
Quickstart installation fails on runtimes installation step [main branch] #370
Closed
@ckadner ckadner merged commit 650104c into kserve:main May 9, 2023
@rafvasq rafvasq deleted the fix-quickstart branch May 9, 2023 19:48
@ckadner ckadner mentioned this pull request Aug 1, 2023
Merged
ckadner added a commit that referenced this pull request Aug 2, 2023
@ckadner
doc: Update docs for release v0.11.0 (#414)
e147d28 
- Add tags when pre-pulling images for FVT (`latest`, `v...`)
- Pre-pull minio-examples and minio-dev-examples images for FVT
  - this is one reason for the frequent timeouts in the FVT setup nodes
    - predictor tests using minio-dev-examples
    - storage tests for PVC using minio-examples (non -dev-)
- Update links to `modelmesh` environment variables
- Update install-script and quickstart to clone `main` branch, adding
  note pointing to the most recent stable release, and re-including the
  self-signed cert flag (#364)
- Update required minimum Kubernetes version to `1.23` (HPA
  `autoscaling/v2`)
- Update modelmesh component-versions to `v0.11.0`
- Update release-process docs with additional places where versions need
to be replaced

---------

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
ckadner added a commit that referenced this pull request Aug 2, 2023
@ckadner
doc: Update docs for release v0.11.0 (#414)
f3ed128 
- Add tags when pre-pulling images for FVT (`latest`, `v...`)
- Pre-pull minio-examples and minio-dev-examples images for FVT
  - this is one reason for the frequent timeouts in the FVT setup nodes
    - predictor tests using minio-dev-examples
    - storage tests for PVC using minio-examples (non -dev-)
- Update links to `modelmesh` environment variables
- Update install-script and quickstart to clone `main` branch, adding
  note pointing to the most recent stable release, and re-including the
  self-signed cert flag (#364)
- Update required minimum Kubernetes version to `1.23` (HPA
  `autoscaling/v2`)
- Update modelmesh component-versions to `v0.11.0`
- Update release-process docs with additional places where versions need
to be replaced

---------

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
(cherry picked from commit e147d28)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckadner ckadner ckadner approved these changes

@Jooho Jooho Awaiting requested review from Jooho

@tjohnson31415 tjohnson31415 Awaiting requested review from tjohnson31415

Assignees

@tjohnson31415 tjohnson31415

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quickstart installation fails on runtimes installation step [main branch]
4 participants
@rafvasq @ckadner @kserve-oss-bot @tjohnson31415