Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable FVTs to be triggered manually #432

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Sep 20, 2023

Motivation

It can be helpful to run FVTs on the latest code base to compare run results with those of a current PR.

Modifications

Update FVT workflow definition to run on workflow_dispatch event

Result

TBD

Update FVT to run on workflow_dispatch event


Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner requested a review from rafvasq September 20, 2023 04:13
@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ckadner
To complete the pull request process, please assign njhill after the PR has been reviewed.
You can assign the PR to them by writing /assign @njhill in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit 856b16e into main Sep 20, 2023
2 checks passed
@ckadner ckadner removed the request for review from joerunde October 2, 2023 22:46
@ckadner ckadner self-assigned this Oct 2, 2023
@ckadner ckadner added the test testing related bugs and fixes label Oct 2, 2023
@ckadner ckadner added this to the v0.11.1 milestone Oct 2, 2023
@ckadner ckadner deleted the ckadner-run-fvt-on-workflow-dispatch branch December 2, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test testing related bugs and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants