Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Minor documentation fixes #445

Merged
merged 4 commits into from
Oct 6, 2023
Merged

docs: Minor documentation fixes #445

merged 4 commits into from
Oct 6, 2023

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Oct 5, 2023

  • Add doc link to MM_PAYLOAD_PROCESSORS variable in modelmesh repo
  • Update defunct links for OpenVINO docs
  • Update single-entry 1-dimensional tensor shapes
  • CamelCase Modelmesh
  • Add create namespace command to FVT setup instructions
  • Add command to delete namespace in Quickstart cleanup instructions -

@ckadner
docs: Minor documentation fixes
7ab35b6 
- Add doc link to MM_PAYLOAD_PROCESSORS variable in modelmesh repo
- Update defunct links for OpenVINO docs
- Update single-entry 1-dimensional tensor shapes
- CamelCase Modelmesh
- Add create namespace command to FVT setup instructions
- Add command to delete namespace in Quickstart cleanup instructions
-

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner added the documentation Improvements or additions to documentation label Oct 5, 2023
@kserve-oss-bot kserve-oss-bot requested a review from njhill October 5, 2023 23:35
@ckadner
lint
e3ff761 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Copy link
Member Author

ckadner commented Oct 6, 2023

@rafvasq -- buncha small potatoes when you hava min -- thx

rafvasq
rafvasq requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Christian - just a small change to confirm for the quickstart doc!

docs/quickstart.md Outdated Show resolved Hide resolved
ckadner added 2 commits October 6, 2023 10:30
@ckadner
Inference result datatype INT64
09d3d5b 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Merge branch 'main' into doc_updates
f99cdee
@ckadner ckadner requested a review from rafvasq October 6, 2023 17:39
rafvasq
rafvasq approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit 454d9ec into kserve:main Oct 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafvasq rafvasq rafvasq approved these changes

Assignees

@rafvasq rafvasq

Labels
approved documentation Improvements or additions to documentation lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckadner @kserve-oss-bot @rafvasq