Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Copy-edit TLS.md #457

Merged
merged 7 commits into from
Nov 24, 2023
Merged

docs: Copy-edit TLS.md #457

merged 7 commits into from
Nov 24, 2023

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Nov 9, 2023

Copy-edits TLS documentation while testing and fixing commands.

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq rafvasq marked this pull request as ready for review November 22, 2023 21:33
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafvasq -- your copy-edits look good. I would just make the script blocks more bullet proof :-)

docs/configuration/tls.md Outdated Show resolved Hide resolved
docs/configuration/tls.md Outdated Show resolved Hide resolved
docs/configuration/tls.md Outdated Show resolved Hide resolved
docs/configuration/tls.md Show resolved Hide resolved
docs/configuration/tls.md Show resolved Hide resolved
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq rafvasq requested a review from ckadner November 24, 2023 18:00
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @rafvasq

/approve
/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit bba0cec into kserve:main Nov 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants