Replace "foo" string with a less generic one #465
Conversation
israel-hdez
force-pushed
the
odh-114-replace-foo-string
branch
from
5b30bf8
to
bf72b2a
Compare
|
@israel-hdez it might need a rebase. |
If template parsing fails, the "foo" string would appear in pod logs. This should be very hard to happen, since the template is built-in. Changing, simply, to have more meaningful logs. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
israel-hdez
force-pushed
the
odh-114-replace-foo-string
branch
from
bf72b2a
to
d8fe432
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I think somebody needs to also say |
I just wanted to give @spolti the final say since he originally requested changes. |
He is on vacation right now. |
|
I'll take care of it since he's on vacation! /lgtm |
|
Thanks, @rafvasq . |
If template parsing fails, the "foo" string would appear in pod logs. This should be very hard to happen, since the template is built-in. Changing, simply, to have more meaningful logs.
Fixes opendatahub-io#114