Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Per-model metrics labels should be disabled by default
Browse files Browse the repository at this point in the history
Motivation

#90 introduced support for per-model prometheus metrics but the intention was not to change the default behaviour and have this as something enabled explicitly via configuration.

However, it was inadvertently made the default.

Modifications

Change default behaviour to not include modelId/vModelId prometheus metric labels. This is important because model-mesh was designed primarily for use cases where there is a very large and changing number of individual models and those scenarios would result in a much greater number of individual metrics than prometheus can handle.

Result

Original behaviour restored

Signed-off-by: Nick Hill <nickhill@us.ibm.com>
njhill committed Nov 16, 2023
1 parent 8b36883 commit bb1688f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/java/com/ibm/watson/modelmesh/Metrics.java
Original file line number Diff line number Diff line change
@@ -172,7 +172,7 @@ public PrometheusMetrics(Map<String, String> params, Map<String, String> infoMet
int port = 2112;
boolean shortNames = true;
boolean https = true;
boolean perModelMetricsEnabled = true;
boolean perModelMetricsEnabled = false;
String memMetrics = "all"; // default to all
for (Entry<String, String> ent : params.entrySet()) {
switch (ent.getKey()) {

0 comments on commit bb1688f

Please sign in to comment.