fix: Fix cache accounting in loading failures case #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation Some issues have been observed in production where the cache appears to get into a broken state, including a cascading eviction of all models. Modifications - Fix cache accounting in loading failure + unload case - Eagerly remove expired failure records from cache - Correct misworded log message - Log some internal cache values along with published instance records, to faciliate further diagnoses - Increase load failure expiry times Result Hopefully fixed cache accounting issue Signed-off-by: Nick Hill <nickhill@us.ibm.com>
njhill
force-pushed
the
fix-fail-accounting
branch
from
58b46f7
to
9d2c7c3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some issues have been observed in production where the cache appears to get into a broken state, including a cascading eviction of all models.
Modifications
Result
Hopefully fixed cache accounting issue