mwa(front): Link to corresponding PVC in VWA #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Link to a Volume details page from the Storage URI in overview and details tab, only when it links to a PVC. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Link to a Volume details page from the Storage URI column, only when it links to a PVC. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
orfeas-k
force-pushed
the
feature-orfeas-mwa-link-to-volume
branch
from
07e5390
to
6c8cecb
Compare
|
Tested the PR and it works as expected, thank you @orfeas-k! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd, orfeas-k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now have fully functional details pages for PVCs and Notebooks, it would improve the UX if it was easy for users to navigate between them. That's why we would like to have links wherever there is a reference to an object, for which we support a details page. Following this train of thought, this PR introduces:
OVERVIEWandDETAILStab, only when that links to a PVC.