mwa(front): Update the use of SnackBarService #63
Conversation
|
@tasos-ale could you take a stab at this? /cc @tasos-ale |
|
@kimwnasptd: GitHub didn't allow me to request PR reviews from the following users: tasos-ale. Note that only kserve members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@orfeas-k can you please rebase this PR and resolve those conflicts? |
Update COMMIT file to include latest changes Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Update the use of SnackBarService in order to pass required data via a `config` object and provide MAT_SNACK_BAR_DEFAULT_OPTIONS. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
orfeas-k
force-pushed
the
feature-orfeas-mwa-update-snackbar
branch
from
60d307f
to
8c2aed5
Compare
|
I rebased and pushed @tasos-ale ! |
|
@kimwnasptd LGTM, we can merge it. @orfeas-k thanks! |
|
Thanks for taking a look! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd, orfeas-k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Following this PR and the changes implemented in SnackBarService of KF common library, this PR updates the use of SnackBarService in order to pass required data via a
configobject and provideMAT_SNACK_BAR_DEFAULT_OPTIONS.