mwa: Improve how MWA exposes errors #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update COMMIT file to include the latest changes. Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
Extend the backend to fetch the events of an ISVC. Signed-off-by: Elena Zioga <elena@arrikto.com>
Add Events tab to show the available events of an ISVC. Signed-off-by: Elena Zioga <elena@arrikto.com>
The frontend functions follow the logic: - Check the .status.conditions, since they have the one-liner reason and a message and show the first condition in order. - If there are no conditions, show a warning icon with a message that explains there is no status and urge users to take a look at the events. Signed-off-by: Elena Zioga <elena@arrikto.com>
* Use the lib-status-icon component to display the status icon. * Add an admonition with a detailed message on the current status bellow the ISVC's name. Signed-off-by: Elena Zioga <elena@arrikto.com>
Remove status item from the Overview tab, since we've added an admonition with a detailed message on the current status to the details page. Signed-off-by: Elena Zioga <elena@arrikto.com>
Remove status item from the Details tab, since we've added an admonition with a detailed message on the current status to the details page. Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elenzio9, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, MWA doesn't properly expose the error state when errors occur in the underlying resources that the app is showing. Our goal it to further improve how the app exposes errors to better inform users what is happening. We want it to be clear to users when there's progress being made or when something unexpected has happened. So, in this PR:
Frontend
a. Check for a
Readycondition withstatus: trueand if exists, it shows a ✅.b. Check the
.status.conditionsand show the first condition of the ordered list, since it has the one-linerreasonand amessage.c. If there are no conditions, it shows a
EVENTStab that shows the events emitted for the specific ISVC, like we do for the other apps.OVERVIEWandDETAILStabs, as we've added the admonition to the details page.Backend
Screenshots
Related PR: kubeflow/kubeflow#6952