Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mwa(front): Fix custom predictor bug #79

Merged
merged 1 commit into from
May 22, 2024

Conversation

tasos-ale
Copy link
Contributor

Fix the bug where the getPredictorExtensionSpec() function throws an error when a custom predictor spec does not have a containers field. With this bug, a user could not see the Model Servers on the UI’s main page.

Fix the bug where the getPredictorExtensionSpec() function throws an
error when a custom predictor spec does not have a containers field.
With this bug, a user could not see the Model Servers on the UI’s
main page.

Signed-off-by: Tasos Alexiou <anastasios.alexiou@hpe.com>
@kimwnasptd
Copy link
Contributor

Thank you @tasos-ale!

/lgtm
/approve

Copy link

oss-prow-bot bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd, tasos-ale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun yuzisun merged commit 880e635 into kserve:master May 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants