Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Siyuan upgrade node version in dockerfile #83

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/test-node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 12
node-version: 16

- name: Format code
run: |
Expand All @@ -26,6 +26,7 @@ jobs:

- name: Lint code
run: |
npm install @angular/cli@12.2.17 --prefix ./frontend
cd frontend
npm run lint-check

Expand All @@ -40,7 +41,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 12
node-version: 16

- name: Fetch Kubeflow and install common code dependencies
run: |
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ COPY --from=fetch-kubeflow-kubeflow $BACKEND_LIB .
RUN python setup.py sdist bdist_wheel

# --- Build the frontend kubeflow library ---
FROM node:12-buster-slim AS frontend-kubeflow-lib
FROM node:16-buster-slim AS frontend-kubeflow-lib

WORKDIR /src

Expand All @@ -32,7 +32,7 @@ COPY --from=fetch-kubeflow-kubeflow $LIB/ ./
RUN npm run build

# --- Build the frontend ---
FROM node:12-buster-slim AS frontend
FROM node:16-buster-slim AS frontend

WORKDIR /src
COPY ./frontend/package*.json ./
Expand Down
8 changes: 6 additions & 2 deletions OWNERS
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
approvers:
- kimwnasptd
- yuzisun
- rimolive
- juliusvonkohout
reviewers:
- elikatsis
- StefanoFioravanzo
- kimwnasptd
- yuzisun
- rimolive
- juliusvonkohout
Loading
Loading