Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Build not push on Pull Request #22

Merged
merged 1 commit into from
Jan 10, 2023
Merged

chore: Build not push on Pull Request #22

merged 1 commit into from
Jan 10, 2023

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Jan 10, 2023

For Pull Requests we should run the docker build but not docker push to verify that code changes, changes to the Dockerfile, or changed dependencies do not break the Docker build.

/cc @njhill
/assign @njhill

@ckadner
chore: Build not push on Pull Request
47192d9 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@njhill
Copy link
Member

njhill commented Jan 10, 2023

/lgtm

@njhill njhill merged commit bac0dd9 into kserve:main Jan 10, 2023
ddelange added a commit to ddelange/rest-proxy that referenced this pull request Jan 16, 2023
@ddelange
Merge branch 'main' of https://github.com/kserve/rest-proxy into patch-1
b20375f 
* 'main' of https://github.com/kserve/rest-proxy:
  chore: Build not push on Pull Request (kserve#22)
  Revert "Push multi-arch docker image (kserve#18)" (kserve#21)
  chore: Update dependencies (kserve#19)
  Push multi-arch docker image (kserve#18)
This was referenced Jan 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhill njhill njhill approved these changes

@rafvasq rafvasq Awaiting requested review from rafvasq

Assignees

@njhill njhill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckadner @njhill