chore: Add code generation to Makefile #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pre-install grpc-gateway plugin in developer Docker image * Add `generate` make target to run protoc and automatically download required .proto files * Add developer instructions to README.md Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
|
@rafvasq -- when you get a chance, could you try the revised developer setup and instructions?
|
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
rafvasq
approved these changes
Sep 28, 2023
|
/reopen |
|
@ckadner: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
spolti
referenced
this pull request
in spolti/rest-proxy
Jan 10, 2024
* Pre-install grpc-gateway plugin in developer Docker image * Add `generate` make target to run protoc and download required .proto files * Add developer instructions to README.md --------- Signed-off-by: Christian Kadner <ckadner@us.ibm.com> Signed-off-by: Spolti <fspolti@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generatemake target to run protoc and automatically download required .proto files