chore: Upgrade Golang version from 1.18 to 1.19 #28

spolti · 2023-10-26T19:49:45Z

Fixed lint issues:

Can't run linter goanalysis_metalinter: goanalysis_metalinter: buildir: package "netip" (isInitialPkg: false, needAnalyzeSource: true): in net/netip.AddrFromSlice: cannot convert Load <[]byte> t0 ([]byte) to [4]byte

Warnings:

WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.

ckadner · 2023-10-28T07:48:34Z

Hi @spolti -- could you separate the changes into 2 PRs -- without RHODS or CVE numbers in the title ;-)

"chore: Upgrade Go from 1.18 to 1.19"
"chore(deps): Upgrade golang.org/x/net and golang.org/grpc"

spolti · 2023-10-31T12:41:24Z

Hi @ckadner, sure.

spolti · 2023-10-31T12:53:43Z

Done, dependencies upgrade: #30

@ckadner I don't have permissions to see the dependabot issues, are they still related only with the Go lang update? Or should we update the above PR's descrioption?

ckadner

Thanks @spolti -- My apologies for the delayed review.

Dockerfile

go.mod

scripts/fmt.sh

spolti · 2023-11-16T20:07:56Z

the CI issue will be fixed by #30

ckadner · 2023-11-23T02:04:45Z

Hi @spolti -- I added another comment on a thread from my past review. Other than that, your PR looks good 👍🏻

ckadner

Thanks @spolti -- your changes look good. Just need to update the .pre-commit.log configuration. See comment above.

spolti · 2023-11-23T19:33:54Z

Thanks @ckadner, sry for the late reply, busy day.

chore: Upgrade Go from 1.18 to 1.19 Plus: Fixes lint issues: - Can't run linter goanalysis_metalinter: goanalysis_metalinter: buildir: package "netip" (isInitialPkg: false, needAnalyzeSource: true): in net/netip.AddrFromSlice: cannot convert Load <[]byte> t0 ([]byte) to [4]byte Warnings: WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. Signed-off-by: Spolti <fspolti@redhat.com>

Signed-off-by: Spolti <fspolti@redhat.com>

rafvasq

@ckadner, I tested this change too with no issues. Similar to kserve/modelmesh-runtime-adapter#68 (comment):

I deployed MM with your updates to this component and deployed/inferenced an inference service as outlined in the quickstart guide :)

Signed-off-by: Spolti <fspolti@redhat.com>

ckadner

Thanks @spolti -- just a small nit pick

.gitignore

Signed-off-by: Spolti <fspolti@redhat.com>

ckadner

Great! Thanks @spolti

/lgtm
/approve

oss-prow-bot · 2023-11-30T01:22:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ckadner, spolti

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- Remove the linters for "deadcode", "structcheck", "varcheck" - Use "os" packages instead of deprecated "io/ioutil" (SA1019) - Capture pre-commit output in a local log file --------- Signed-off-by: Spolti <fspolti@redhat.com>

ckadner requested review from ckadner, njhill and rafvasq October 28, 2023 07:44

ckadner marked this pull request as draft October 28, 2023 07:44

spolti force-pushed the CVE-2023-44487 branch 3 times, most recently from ccf4a0e to 0defb5d Compare October 31, 2023 12:52

spolti marked this pull request as ready for review October 31, 2023 12:52

spolti changed the title ~~[RHODS-12555] - CVE-2023-44487~~ CVE-2023-44487 Oct 31, 2023

spolti mentioned this pull request Nov 1, 2023

Address High vulnerabilities in ModelMesh SNYK reports opendatahub-io/modelmesh-serving#249

Closed

8 tasks

ckadner changed the title ~~CVE-2023-44487~~ chore: Upgrade Golang version from 1.17 to 1.19 Nov 14, 2023

ckadner changed the title ~~chore: Upgrade Golang version from 1.17 to 1.19~~ chore: Upgrade Golang version from 1.18 to 1.19 Nov 14, 2023

ckadner requested changes Nov 14, 2023

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

go.mod Show resolved Hide resolved

scripts/fmt.sh Outdated Show resolved Hide resolved

scripts/fmt.sh Outdated Show resolved Hide resolved

spolti force-pushed the CVE-2023-44487 branch 2 times, most recently from 76475fc to f2f6ca2 Compare November 21, 2023 19:37

spolti requested a review from ckadner November 22, 2023 13:57

ckadner mentioned this pull request Nov 23, 2023

Update Go to supported version (1.20) kserve/modelmesh-serving#452

Closed

ckadner requested changes Nov 23, 2023

View reviewed changes

ckadner added this to the v0.11.2 milestone Nov 23, 2023

spolti added 2 commits November 23, 2023 17:33

review suggestions

146ac2c

Signed-off-by: Spolti <fspolti@redhat.com>

rafvasq reviewed Nov 23, 2023

View reviewed changes

rename the pre-commint log file

0780d31

Signed-off-by: Spolti <fspolti@redhat.com>

spolti force-pushed the CVE-2023-44487 branch from f2f6ca2 to 0780d31 Compare November 28, 2023 19:03

ckadner requested changes Nov 28, 2023

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

add .dockerignore file

c66c7df

Signed-off-by: Spolti <fspolti@redhat.com>

spolti force-pushed the CVE-2023-44487 branch from c4f0f0e to c66c7df Compare November 29, 2023 14:21

ckadner approved these changes Nov 30, 2023

View reviewed changes

oss-prow-bot bot assigned ckadner Nov 30, 2023

oss-prow-bot bot added the lgtm label Nov 30, 2023

ckadner merged commit 61dc700 into kserve:main Nov 30, 2023
5 of 6 checks passed

spolti deleted the CVE-2023-44487 branch November 30, 2023 17:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Upgrade Golang version from 1.18 to 1.19 #28

chore: Upgrade Golang version from 1.18 to 1.19 #28

spolti commented Oct 26, 2023 •

edited by ckadner

Loading

ckadner commented Oct 28, 2023 •

edited

Loading

spolti commented Oct 31, 2023

spolti commented Oct 31, 2023

ckadner left a comment

spolti commented Nov 16, 2023

ckadner commented Nov 23, 2023 •

edited

Loading

ckadner left a comment •

edited

Loading

spolti commented Nov 23, 2023

rafvasq left a comment

ckadner left a comment

ckadner left a comment

oss-prow-bot bot commented Nov 30, 2023

chore: Upgrade Golang version from 1.18 to 1.19 #28

chore: Upgrade Golang version from 1.18 to 1.19 #28

Conversation

spolti commented Oct 26, 2023 • edited by ckadner Loading

ckadner commented Oct 28, 2023 • edited Loading

spolti commented Oct 31, 2023

spolti commented Oct 31, 2023

ckadner left a comment

Choose a reason for hiding this comment

spolti commented Nov 16, 2023

ckadner commented Nov 23, 2023 • edited Loading

ckadner left a comment • edited Loading

Choose a reason for hiding this comment

spolti commented Nov 23, 2023

rafvasq left a comment

Choose a reason for hiding this comment

ckadner left a comment

Choose a reason for hiding this comment

ckadner left a comment

Choose a reason for hiding this comment

oss-prow-bot bot commented Nov 30, 2023

spolti commented Oct 26, 2023 •

edited by ckadner

Loading

ckadner commented Oct 28, 2023 •

edited

Loading

ckadner commented Nov 23, 2023 •

edited

Loading

ckadner left a comment •

edited

Loading