Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Specify Python 3.8 in Dockerfile #34

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Nov 17, 2023

Motivation

Build/test failures due to the wrong Python version.

Modifications

Specify and link python38.

Result

Working builds

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
@rafvasq rafvasq requested a review from ckadner November 17, 2023 21:24
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ckadner ckadner merged commit 7b8af3d into kserve:main Nov 17, 2023
5 checks passed
spolti referenced this pull request in spolti/rest-proxy Nov 21, 2023
Specify and link python38 to fix build/test failures due to
the wrong Python version (3.6) being used from base image.

---------

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
openshift-merge-bot bot referenced this pull request in opendatahub-io/rest-proxy Nov 22, 2023
fix: Specify Python 3.8 in Dockerfile (#34)
@ckadner ckadner added this to the v0.11.2 milestone Nov 23, 2023
spolti referenced this pull request in spolti/rest-proxy Jan 10, 2024
Specify and link python38 to fix build/test failures due to
the wrong Python version (3.6) being used from base image.

---------

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Spolti <fspolti@redhat.com>
spolti referenced this pull request in spolti/rest-proxy Jan 10, 2024
Specify and link python38 to fix build/test failures due to
the wrong Python version (3.6) being used from base image.

---------

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Spolti <fspolti@redhat.com>
spolti referenced this pull request in spolti/rest-proxy Jan 11, 2024
Specify and link python38 to fix build/test failures due to
the wrong Python version (3.6) being used from base image.

---------

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Spolti <fspolti@redhat.com>
openshift-merge-bot bot referenced this pull request in opendatahub-io/rest-proxy Jan 11, 2024
fix: Specify Python 3.8 in Dockerfile (#34)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants