Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the develop container image build #46

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

spolti
Copy link
Contributor

@spolti spolti commented Sep 9, 2024

chore: Fix the following issue while tring to build the develop container,
(reproducible locally with: make build):

	go: downloading gopkg.in/yaml.v3 v3.0.1
	/root/go/pkg/mod/github.com/grpc-ecosystem/grpc-gateway/v2@v2.15.0/protoc-gen-grpc-gateway/main.go:18:2: github.com/golang/glog@v1.2.1: missing go.sum entry for go.mod file; to add it:
        	go mod download github.com/golang/glog

Dockerfile Outdated Show resolved Hide resolved
chore:	Fix the following issue while tring to build the develop container,
	(reproducible locally with: `make build`):
	```
	go: downloading gopkg.in/yaml.v3 v3.0.1
	/root/go/pkg/mod/github.com/grpc-ecosystem/grpc-gateway/v2@v2.15.0/protoc-gen-grpc-gateway/main.go:18:2: github.com/golang/glog@v1.2.1: missing go.sum entry for go.mod file; to add it:
        	go mod download github.com/golang/glog
	```

Signed-off-by: Spolti <fspolti@redhat.com>
Copy link
Collaborator

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@Jooho
Copy link

Jooho commented Sep 10, 2024

/lgtm

Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rafvasq rafvasq merged commit 37aa1cd into kserve:main Sep 11, 2024
2 checks passed
@spolti spolti deleted the fixDevelopBuild branch September 11, 2024 16:07
@spolti
Copy link
Contributor Author

spolti commented Sep 11, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants