Add canary rollout documentation and example #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elastic-nobel-0aef7a ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yuzisun
reviewed
May 12, 2022
|
@alexagriffith Can you help sign off your commit following https://github.com/kserve/website/pull/137/checks?check_run_id=6411042959 Also need to link your tutorial on the main index |
Signed-off-by: agriffith50 <agriffith50@bloomberg.net>
Signed-off-by: agriffith50 <agriffith50@bloomberg.net>
|
/lgtm |
remove shell since it causes weird formatting on the website
add bash keyword and remove the extra tick causing formatting issues
|
thanks @alexagriffith !! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexagriffith, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yuzisun
pushed a commit
to Suresh-Nakkeran/website
that referenced
this pull request
May 28, 2022
* add canary rollout documentation Signed-off-by: agriffith50 <agriffith50@bloomberg.net> * make docs findable on website Signed-off-by: agriffith50 <agriffith50@bloomberg.net> * remove "shell" remove shell since it causes weird formatting on the website * fixing format issue add bash keyword and remove the extra tick causing formatting issues Co-authored-by: agriffith50 <agriffith50@bloomberg.net> Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fixes #issue-number" or "Add description of the problem this PR solves"
Proposed Changes
This PR adds and updates the canary documentation from the kserve/kserve repo https://github.com/kserve/kserve/tree/master/docs/samples/v1beta1/rollout - it adds a rollout tab to the Kserve website as well. That way, when more rollout options are available, we can add them there. There is also a step by step example of how to implement a simple canary rollout strategy.