Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing capabilities using --sign #23

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

DeveloperMarius
Copy link
Contributor

Hello @ksg97031,

first of all thank you for this project. It simplifies my workflow a lot!
I currently only have the problem that I have to manually sign the apk after injecting the frida gadget with your tool.
Otherwise, adb install app.apk will throw:
adb: failed to install app.apk: Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES: Failed to collect certificates from /data/app/vmdl1905114498.tmp/base.apk: Attempt to get length of null array]

This Pull Request adds support for an optional --sign flag that allows to automatically sign the apk after it is build with apktool. It is using the apk signer by https://github.com/patrickfav/uber-apk-signer.
I'm, looking forward to your feedback and suggestions.

Thank you,
~ Marius

@DeveloperMarius
Copy link
Contributor Author

Hey,
I cannot find out what errors were thrown by "Codacy Static Code Analysis".
I would appreciate some if you would let me know when you have more information.
~ Marius

@ksg97031
Copy link
Owner

ksg97031 commented Aug 6, 2024

@DeveloperMarius
Codacy issue does not appear to be related to your code.
The feature you requested looks great. I'll work on it within a day.
Thank you for contributing!

Copy link
Owner

@ksg97031 ksg97031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link

sonarqubecloud bot commented Aug 7, 2024

@ksg97031 ksg97031 merged commit c43fe15 into ksg97031:trunk Aug 7, 2024
1 of 2 checks passed
@DeveloperMarius
Copy link
Contributor Author

Hey,

thank you for approving my PR 🥳.
I wish you a good day!

~ Marius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants