Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Drone CI #111

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Add support for Drone CI #111

merged 1 commit into from
Apr 3, 2021

Conversation

jvia
Copy link
Contributor

@jvia jvia commented Mar 31, 2021

@kt3k
Copy link
Owner

kt3k commented Apr 1, 2021

Thanks!
Can you add test case in src/test/groovy/org/kt3k/gradle/plugin/coveralls/domain/ServiceInfoFactoryTest.groovy?

@jvia
Copy link
Contributor Author

jvia commented Apr 2, 2021

Added a test case.

kt3k
kt3k approved these changes Apr 3, 2021
View reviewed changes
Copy link
Owner

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jvia Thanks! LGTM

@kt3k kt3k merged commit cf0ad31 into kt3k:master Apr 3, 2021
@jvia
Copy link
Contributor Author

jvia commented Apr 6, 2021 •
edited
Loading

@kt3k Thanks for merging! Would you be able to cut a release?

@kt3k
Copy link
Owner

kt3k commented Apr 7, 2021

@jvia Released as v2.12.0! https://plugins.gradle.org/plugin/com.github.kt3k.coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvia @kt3k