Added Android Plugin support. Pulls in the Main Source. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thanks for your contribution! Sorry for some inconvenience. And even if we released that feature, this change would be useful for android projects because it enables users to upload android app coverage without configuration. (In my opinion, the capability without any configuration is important for this kind of tool.) So I'll merge this. Thanks, |
kt3k
added a commit
that referenced
this pull request
Jun 25, 2014
Added Android Plugin support. Pulls in the Main Source.
|
Deployed as v0.5.0. Thanks, |
|
@kt3k no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the Main
sourceSetof the Android plugins (Android/Library) they both inherit from the BasePlugin now.This shouldn't be nessary, but setting https://github.com/kt3k/coveralls-gradle-plugin/blob/master/src/main/groovy/org/kt3k/gradle/plugin/CoverallsPluginExtension.groovy#L26 has no effect on the
project.extentions.coveralls.sourceSetsproperty.If you fix that then, this becomes slightly obsolete.