Correctly extract PR identifier for CircleCI builds #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not super clear on why Cobertura isn't picking up results of ServiceInfoFactoryTest, but it seems to only hit the Travis branch even when running locally. |
|
Thanks for the contribution. The change itself makes sense. Thanks. The coverage reporter has been broken since the plugin switched to 2.0 ecosystem. ( I've been looking for alternatives but I haven't found one yet.) |
kt3k
added a commit
that referenced
this pull request
Jan 24, 2016
Correctly extract PR identifier for CircleCI builds
|
any thoughts when you might release this? |
|
Sorry for being late. I've published this as v2.6.1 to maven and bintray! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.