Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ghprbPullLink with ghprbPullId in ServiceInfoFactory.groovy #79

Merged
merged 3 commits into from
Oct 17, 2017
Merged

Replace ghprbPullLink with ghprbPullId in ServiceInfoFactory.groovy #79

merged 3 commits into from
Oct 17, 2017

Conversation

jettbow
Copy link
Contributor

@jettbow jettbow commented Oct 16, 2017

serviceInfo.servicePullRequest should be assigned as Id of a PR.

@kt3k
Copy link
Owner

kt3k commented Oct 17, 2017 •
edited
Loading

Thanks for the contribution! The change makes sense to me. Can you update the test case for this class as well?

(see: https://travis-ci.org/kt3k/coveralls-gradle-plugin/jobs/288501355 )

@jettbow
Copy link
Contributor Author

jettbow commented Oct 17, 2017

Sure! Updated.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.077% when pulling 02d996c on jettbow:master into 992d48c on kt3k:master.

@jettbow
Copy link
Contributor Author

jettbow commented Oct 17, 2017

@kt3k Fixed.

kt3k
kt3k approved these changes Oct 17, 2017
View reviewed changes
Copy link
Owner

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@kt3k kt3k merged commit 87e5296 into kt3k:master Oct 17, 2017
@kt3k
Copy link
Owner

kt3k commented Oct 17, 2017

Released as v2.8.2 https://plugins.gradle.org/plugin/com.github.kt3k.coveralls http://repo1.maven.org/maven2/org/kt3k/gradle/plugin/coveralls-gradle-plugin/2.8.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jettbow @kt3k @coveralls