Fix missing charset for static js, css and svg resources #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marychatte
force-pushed
the
marychatte/KTOR-6655-static-js-css-and-svg-resources-misses-charset
branch
from
d47f1e2
to
67276ce
Compare
bjhham
approved these changes
Jun 13, 2024
| contentType.match(ContentType.Image.SVG) && contentType.charset() == null -> contentType.withCharset( | ||
| Charsets.UTF_8 | ||
| ) | ||
|
|
There was a problem hiding this comment.
Seems like there's quite a few other text-based mime types hidden under "application/*", like xml, rss, soap. Could add them in while you're in the neighbourhood.
marychatte
force-pushed
the
marychatte/KTOR-6655-static-js-css-and-svg-resources-misses-charset
branch
from
f697e22
to
4c2012e
Compare
marychatte
force-pushed
the
marychatte/KTOR-6655-static-js-css-and-svg-resources-misses-charset
branch
from
4c2012e
to
1b1657f
Compare
marychatte
deleted the
marychatte/KTOR-6655-static-js-css-and-svg-resources-misses-charset
branch
marychatte
added a commit
that referenced
this pull request
Jun 18, 2024
(cherry picked from commit c892bc0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Server, Static
Motivation
KTOR-6655
application/javascriptobsoleted in favor oftext/javascript(https://www.iana.org/assignments/media-types/application/javascript)svg, it's optional parameter (https://www.w3.org/TR/SVG/mimereg.html)