Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to begin at the top of the list (fix #126) #130

Merged
merged 4 commits into from
Nov 23, 2021

Conversation

r-darwish
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #130 (678c230) into master (2123b55) will decrease coverage by 1.23%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   86.96%   85.73%   -1.24%     
==========================================
  Files           5        5              
  Lines         752      764      +12     
==========================================
+ Hits          654      655       +1     
- Misses         85       95      +10     
- Partials       13       14       +1     

Copy link
Owner

@ktr0731 ktr0731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment. Could you look when you have time?

option.go Outdated Show resolved Hide resolved
r-darwish and others added 3 commits November 21, 2021 20:16
Co-authored-by: ktr <ktr@syfm.me>
Copy link
Owner

@ktr0731 ktr0731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@ktr0731 ktr0731 merged commit 35bbbaa into ktr0731:master Nov 23, 2021
@r-darwish r-darwish deleted the begin-at-top branch November 23, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants