add initial query and select one options #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ktr0731 Would you mind taking a look at this PR? I'd really appreciate if you could to take a quick glance. |
ktr0731
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
@wsny @piotrkubisa
Sorry for the late reply. I think it makes sense to both of these features, and its implementation seems great to me.
Thank you for submitting PR!
|
No problem @ktr0731. You have put a tremendous amount of effort into creating this fantastic library! Thank you for your time and for including our changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started adding these before noticing #182, so slightly duplicates that but adds some more and tests. Addresses open issue #181
This adds functionality for having an initial query provided to the
findaction (likefzf --query) and the ability to skip the selection if there is only-item (likefzf --select-1).