revert the chages which migrates terminal library from nsf/termbox-go to gdamore/tcell #47
+361
−736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 85.37% 88.65% +3.28%
==========================================
Files 5 5
Lines 554 485 -69
==========================================
- Hits 473 430 -43
+ Misses 66 40 -26
Partials 15 15 |
|
I understand. |
… to gdamore/tcell
|
This bug is a very deep-rooted problem and may we have a long way to go, but let's do our best... |
tjmtmmnk
added a commit
to tjmtmmnk/go-fuzzyfinder
that referenced
this pull request
Feb 21, 2021
…rmbox-go to gdamore/tcell (ktr0731#47)" This reverts commit f3bcd19. # Conflicts: # go.mod # go.sum
tjmtmmnk
added a commit
to tjmtmmnk/go-fuzzyfinder
that referenced
this pull request
Feb 26, 2021
…rmbox-go to gdamore/tcell (ktr0731#47)" This reverts commit f3bcd19. # Conflicts: # go.mod # go.sum
tjmtmmnk
added a commit
to tjmtmmnk/go-fuzzyfinder
that referenced
this pull request
Mar 12, 2021
…rmbox-go to gdamore/tcell (ktr0731#47)" This reverts commit f3bcd19. # Conflicts: # go.mod # go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry for @tjmtmmnk, but I decided to revert a Pull Request which migrates the terminal library from
nsf/termbox-gotogdamore/tcell.gdamore/tcellhas a known bug that causes #17 and #46. A workaround is proposed in gdamore/tcell#194 (comment), but it requires a Cgo dependency and it doesn't reproduce in the latest macOS version (I don't know the detailed cause...).Also, I think that
go-fuzzyfindershouldn't depend on Cgo dependencies because it is designed to use from various platforms such as macOS, Linux, and Windows, etc. Multi-compile is one of the greatest features of Go, so we want to continue to support multi-platform compile.So, I revert the changes and I'm going to wait for terminal library migration until
gdamore/tcellwill be fixed the bug officially.