Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print on errors. #209

Merged
merged 1 commit into from
Jun 18, 2022
Merged

Don't print on errors. #209

merged 1 commit into from
Jun 18, 2022

Conversation

bfabio
Copy link
Contributor

@bfabio bfabio commented Jun 17, 2022

Don't print on errors so consumers of the library can control what they
show to the users.

Don't print on errors so consumers of the library can control what they
show to the users.
Copy link
Owner

@ktrysmt ktrysmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that may be true. Fatal error is left.

@ktrysmt ktrysmt merged commit 3c087ca into ktrysmt:master Jun 18, 2022
@bfabio bfabio deleted the log branch June 18, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants