Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandboxer: Replace features with bin parameter #54

Closed
Burning1020 opened this issue Jul 28, 2023 · 0 comments
Closed

Sandboxer: Replace features with bin parameter #54

Burning1020 opened this issue Jul 28, 2023 · 0 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@Burning1020
Copy link
Member

What should be cleaned up or changed?

Currently there are three features in vmm/sandbox/src/main.rs, cloud_hypervisor,qemu and stratovirt, developer can use --features to control which sandbox that need to build.

We can use src/bin to solve this.

Why is this needed?

However, it's not concise to mix these features in one single file, too many cfgs makes code redundant.

@Burning1020 Burning1020 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 28, 2023
dierbei added a commit to dierbei/kuasar that referenced this issue Jul 29, 2023
dierbei added a commit to dierbei/kuasar that referenced this issue Aug 3, 2023
dierbei added a commit to dierbei/kuasar that referenced this issue Aug 3, 2023
dierbei added a commit to dierbei/kuasar that referenced this issue Aug 3, 2023
dierbei added a commit to dierbei/kuasar that referenced this issue Aug 3, 2023
dierbei added a commit to dierbei/kuasar that referenced this issue Aug 3, 2023
dierbei added a commit to dierbei/kuasar that referenced this issue Aug 11, 2023
dierbei added a commit to dierbei/kuasar that referenced this issue Aug 11, 2023
Fix kuasar-io#54

Signed-off-by: dierbei <1628652790@qq.com>
dierbei added a commit to dierbei/kuasar that referenced this issue Aug 11, 2023
Fix kuasar-io#54

Signed-off-by: dierbei <1628652790@qq.com>
dierbei added a commit to dierbei/kuasar that referenced this issue Aug 11, 2023
Fix kuasar-io#54

Signed-off-by: dierbei <1628652790@qq.com>
dierbei added a commit to dierbei/kuasar that referenced this issue Aug 21, 2023
Fix kuasar-io#54

Signed-off-by: dierbei <1628652790@qq.com>
dierbei added a commit to dierbei/kuasar that referenced this issue Aug 21, 2023
Fix kuasar-io#54

Signed-off-by: dierbei <1628652790@qq.com>
dierbei added a commit to dierbei/kuasar that referenced this issue Aug 21, 2023
Fix kuasar-io#54

Signed-off-by: dierbei <1628652790@qq.com>
dierbei added a commit to dierbei/kuasar that referenced this issue Sep 1, 2023
Fix kuasar-io#54

Signed-off-by: dierbei <1628652790@qq.com>
dierbei added a commit to dierbei/kuasar that referenced this issue Sep 1, 2023
Fix kuasar-io#54

Signed-off-by: dierbei <1628652790@qq.com>
dierbei added a commit to dierbei/kuasar that referenced this issue Sep 1, 2023
Fix kuasar-io#54

Signed-off-by: dierbei <1628652790@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

1 participant