vmm: setup hosts, hostname and resolv.conf files #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burning1020
force-pushed
the
sandbox-dns
branch
from
5d83eb2
to
77c226c
Compare
Burning1020
force-pushed
the
sandbox-dns
branch
3 times, most recently
from
ddacacb
to
ef99ad8
Compare
abel-von
reviewed
Jan 10, 2024
Burning1020
force-pushed
the
sandbox-dns
branch
7 times, most recently
from
e477400
to
dc0a908
Compare
Burning1020
force-pushed
the
sandbox-dns
branch
4 times, most recently
from
d20fc0a
to
ee2c24c
Compare
If containerd has created these three files, it will append relevant cri mounts to container. If these mounts are defined in Kubernetes Pod Yaml by the end user, they will also exist in container mounts. So anyway, in the above cases, vmm-sandboxer should not append any mounts. If not, vmm-snadboxer should prepare sandbox files and covert them into oci mounts before sandbox starts. The hostname should be set to either pod hostname or host hostname, the hosts should be set as host, and the DNS should be set either from pod spec or host DNS. Moreover, it's better to set guest DNS if we want to mount some nfs sewrver in guest. Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
Burning1020
force-pushed
the
sandbox-dns
branch
from
ee2c24c
to
efc82fe
Compare
abel-von
reviewed
Jan 11, 2024
Add early_init_call() and late_init_call() for VM initiation. Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
Burning1020
force-pushed
the
sandbox-dns
branch
from
efc82fe
to
1df144a
Compare
abel-von
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If containerd has created these three files, it will append relevant cri mounts to container. If these mounts are defined in Kubernetes Pod Yaml by the end user, they will also exist in container mounts. So anyway, in the above cases, vmm-sandboxer should not append any mounts.
If not, vmm-snadboxer could prepare sandbox files and covert them into oci mounts before sandbox starts. The hostname should be set to either pod hostname or host hostname, the hosts should be set as host, and the DNS should be set either from pod spec or host DNS.
Moreover, it's good to set guest DNS if we want to mount some nfs in guest.