Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmm: fix clippy warning #142

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

morningtzh
Copy link
Contributor

@morningtzh morningtzh commented Jul 31, 2024

This pull request addresses several Clippy warnings and improves overall code formatting. The changes include:

  1. Replace Default::default() with specific struct's default() method where applicable.
  2. Remove usage of expect() function to improve error handling.
  3. Modify wildcard imports (*) to be more specific.
  4. Remove set -x from shell scripts to reduce verbosity.

Additionally, the entire codebase has been reformatted using rustfmt for consistency.

These changes aim to improve code quality, readability, and adherence to Rust best practices. No functional changes have been made to the software.

Please review and let me know if any further modifications are needed.

Signed-off-by: MorningTZH <morningtzh@yeah.net>
@morningtzh morningtzh requested a review from a team as a code owner July 31, 2024 04:09
Copy link
Member

@Burning1020 Burning1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Burning1020 Burning1020 merged commit 040871f into kuasar-io:main Aug 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants