Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building: extra common scriptes for image building and bump ttrpc-compiler #160

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

Burning1020
Copy link
Member

@Burning1020 Burning1020 commented Aug 14, 2024

  1. Extra common building scripts to make it more general for other images.
  2. Bump ttrpc-compiler in creates.io from 0.6.1 to 0.6.2, while ttrpc-compiler(kuasar-io) is still 0.6.1.
# cd vmm/sandbox && cargo vendor
Caused by:
  found duplicate version of package `ttrpc-compiler v0.6.1` vendored from two sources:

  	source 1: registry `crates-io`
  	source 2: https://github.com/kuasar-io/ttrpc-rust.git?branch=v0.7.1-kuasar#db83ba89
Error: Process completed with exit code 101.

This is because both containerd-sandbox and containerd-shim import ttrpc-compile@0.6.1 in different source(crates.io and github/kuasar-io). So I just bump one to 0.6.2.
3. Cargo tests of wasmedge needs the current user have the access to wasmedge lib, somehow it can't be recongized due to the different user of installation and running. We switch to root user in the process of installation.

Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
@Burning1020 Burning1020 requested a review from a team as a code owner August 14, 2024 08:46
@Burning1020 Burning1020 changed the title building: extra common scriptes for image building building: extra common scriptes for image building and bump ttrpc-compiler Aug 15, 2024
`cargo update -p registry+https://github.com/rust-lang/crates.io-index#ttrpc-compiler@0.6.1`

Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
@Burning1020
Copy link
Member Author

Release workflow is green: https://github.com/Burning1020/kuasar/actions/runs/10399930546

Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
@Burning1020 Burning1020 requested a review from a team as a code owner August 15, 2024 08:37
@Vanient Vanient merged commit 837a900 into kuasar-io:main Aug 15, 2024
18 checks passed
@Burning1020 Burning1020 deleted the extra-common-shell branch August 16, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants