[vmm]: support sandbox cgroup management in the host #52
Conversation
flyflypeng
force-pushed
the
support-host-cgroup
branch
6 times, most recently
from
8b00a9a
to
a2aa43a
Compare
flyflypeng
force-pushed
the
support-host-cgroup
branch
4 times, most recently
from
d5f61f4
to
06de8dc
Compare
flyflypeng
force-pushed
the
support-host-cgroup
branch
2 times, most recently
from
14704f1
to
5f89b25
Compare
flyflypeng
force-pushed
the
support-host-cgroup
branch
2 times, most recently
from
bfa8f96
to
9b9f8f4
Compare
vmm/sandbox/src/sandbox.rs
Outdated
| @@ -168,6 +172,24 @@ where | |||
| return Err(Error::AlreadyExist("sandbox".to_string())); | |||
| } | |||
|
|
|||
| let mut sandbox_cgroups = SandboxCgroup::default(); | |||
| let sandbox_cgroup_path = get_sandbox_cgroup_parent_path(&s.sandbox).unwrap(); | |||
There was a problem hiding this comment.
we can not assume that all sandbox has parent cgroup path defined. I think we can not unwrap here.
vmm/sandbox/src/vm.rs
Outdated
| @@ -70,6 +70,8 @@ pub trait VM: Serialize + Sync + Send { | |||
| async fn ping(&self) -> Result<()>; | |||
| fn socket_address(&self) -> String; | |||
| async fn wait_channel(&self) -> Option<Receiver<(u32, i128)>>; | |||
| async fn get_vcpu_threads(&self) -> Result<VcpuThreads>; | |||
| fn get_virtiofsd_pid(&self) -> Option<u32>; | |||
There was a problem hiding this comment.
This is too implementation specific, maybe we can add a method of name "pids()" and return a Vec of all pids related to this virtual machine.
There was a problem hiding this comment.
I create a new struct Pids to encapsulate the vmm related processes pids, now it only contains the vmm_pid & virtiofsd_pid filed. Currently, it only includes the vmm_pid and virtiofsd_pid fields.
In the future, if we need to add more processes pid info, we can simply add new fields to the Struct Pids while maintaining consistency with the pids() trait interface.
vmm/sandbox/src/vm.rs
Outdated
| @@ -70,6 +70,8 @@ pub trait VM: Serialize + Sync + Send { | |||
| async fn ping(&self) -> Result<()>; | |||
| fn socket_address(&self) -> String; | |||
| async fn wait_channel(&self) -> Option<Receiver<(u32, i128)>>; | |||
| async fn get_vcpu_threads(&self) -> Result<VcpuThreads>; | |||
There was a problem hiding this comment.
Shall wen change the name of this method to "vcpus()" ?
There was a problem hiding this comment.
Sure, vcpus func name looks more clearly.
flyflypeng
force-pushed
the
support-host-cgroup
branch
3 times, most recently
from
36fe09d
to
f33b0a0
Compare
fix: kuasar-io#51 reason: 1. limit the vm process resource usage in the specified cgroup dir 2. support pod_overhead conception actually, which limits the non-vcpu type threads of vm process into pod_overhead cgroup dir and set the pod_overhead resources limit in this cgroup dir. Signed-off-by: flyflypeng <flyflyflypeng@gmail.com>
fix: #51
reason: