Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmm task: should kill all process even no bundle #77

Merged
merged 1 commit into from
Aug 31, 2023
Merged

vmm task: should kill all process even no bundle #77

merged 1 commit into from
Aug 31, 2023

Conversation

yuqitao
Copy link
Member

@yuqitao yuqitao commented Aug 31, 2023

Fix: #76

@yuqitao yuqitao requested a review from a team as a code owner August 31, 2023 02:55
@Burning1020
Copy link
Member

Please add some ut tests

@yuqitao
Copy link
Member Author

yuqitao commented Aug 31, 2023

Please add some ut tests

done

@yuqitao
vmm task: should kill all process even no bundle
36c1bee 
Signed-off-by: yuqitao <yuqitao1024@qq.com>
Burning1020
Burning1020 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@Burning1020 Burning1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Burning1020 Burning1020 merged commit 9a7d522 into kuasar-io:main Aug 31, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Burning1020 Burning1020 Burning1020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should kill all processes even though bundle path has been removed
2 participants
@yuqitao @Burning1020