add workflows release #95
Conversation
|
why not merged it? |
|
suggest squash commit to one commit. give more context on your commit log. |
@dierbei Yes, please squash your commits, thanks. |
|
Thanks for the suggestion. Wait a minute, I still need to make some adjustments. |
dierbei
force-pushed
the
workflow-release
branch
from
f63dc29
to
5ca3518
Compare
|
@Burning1020 @xiaods Already rebase. please help me to review, thanks. |
dierbei
force-pushed
the
workflow-release
branch
from
b3d69fd
to
1a2808a
Compare
.github/workflows/release.yaml
Outdated
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Build kuasar.img | ||
| run: RUNTIME=docker make bin/kuasar.img |
There was a problem hiding this comment.
Add sudo to here, refer to: https://github.com/kuasar-io/kuasar/blob/main/.github/workflows/ci.yml#L76
.github/workflows/release.yaml
Outdated
| - buildSandboxer | ||
| - buildShim | ||
| - kuasar-image | ||
| - vmlinux-bin |
There was a problem hiding this comment.
We have vmm quark wasm target in Makefile. Maybe make vmm, make quark and make wasm could make it simple.
dierbei
force-pushed
the
workflow-release
branch
3 times, most recently
from
5827157
to
720d2a3
Compare
dierbei
force-pushed
the
workflow-release
branch
3 times, most recently
from
09ea667
to
0aea580
Compare
| sudo curl -LJO https://github.com/containerd/containerd/releases/download/v1.7.0/containerd-1.7.0-linux-amd64.tar.gz | ||
| sudo mkdir bin && sudo tar -C bin -xzvf containerd-1.7.0-linux-amd64.tar.gz | ||
|
|
||
| sudo tee bin/config.toml > /dev/null <<EOF |
There was a problem hiding this comment.
Is it necessary to add sudo in front of every commands? I mean it is possiable to add it in job.step.run, #95 (comment)
dierbei
force-pushed
the
workflow-release
branch
5 times, most recently
from
8f9ae33
to
22c7c1f
Compare
.github/workflows/release.yaml
Outdated
| timeout-minutes: 30 | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Download and Extract Containerd |
scripts/build/download-containerd.sh
Outdated
| set -e | ||
|
|
||
| git clone https://github.com/kuasar-io/containerd.git | ||
| mkdir bin && make -C containerd bin/containerd && mv containerd/bin/containerd bin |
There was a problem hiding this comment.
Append rm -rf containerd, we need to cleanup.
dierbei
force-pushed
the
workflow-release
branch
from
22c7c1f
to
3cb1dd4
Compare
scripts/build/cargo-vendor.sh
Outdated
| mkdir ../temp | ||
| cp -r ./* ../temp/ | ||
| tar -czvf $VENDOR_NAME -C ../temp . |
There was a problem hiding this comment.
It's better to place codes kuasar-vx.y.z-vendor folder, like:
# tree -L 2
.
├── kuasar-v0.1.0-vendor
│ ├── ADOPTERS.md
│ ├── CHANGELOG
│ ├── CODE_OF_CONDUCT.md
│ ├── CONTRIBUTING.md
│ ├── docs
│ ├── examples
│ ├── LICENSE
│ ├── MAINTAINERS.md
│ ├── Makefile
│ ├── quark
│ ├── README.md
│ ├── ROADMAP.md
│ ├── shim
│ ├── tests
│ ├── vmm
│ └── wasm
└── kuasar-v0.1.0-vendor.tar.gzSo the scripts should be:
VENDOR_DIR=${GITHUB_REF:10}-vendor
mkdir -p /tmp/VENDOR_DIR
cp -r ./* /tmp/VENDOR_DIR/
tar -czvf $VENDOR_NAME /tmp/VENDOR_DIR/
rm -rf /tmp/VENDOR_DIR
.github/workflows/release.yaml
Outdated
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Build Containerd | ||
| run: sudo -E ./scripts/build/download-containerd.sh |
There was a problem hiding this comment.
build-containerd.sh, not donwload-containerd.sh
dierbei
force-pushed
the
workflow-release
branch
3 times, most recently
from
d4e1cfe
to
85c6f52
Compare
Signed-off-by: dierbei <1628652790@qq.com>
dierbei
force-pushed
the
workflow-release
branch
from
85c6f52
to
fb349df
Compare
Fix #81