vmm: support VFIO device #99
Conversation
Burning1020
commented
Dec 4, 2023
•
Burning1020
commented
- Support VFIO device in vmm.
- Run libc::connect() in spawn_blocking to avoid blocking other task.
- Return OK() if sandbox is in CREATED state.
- Return io error in cmd pre_exec
Burning1020
force-pushed
the
vmm-vfio
branch
12 times, most recently
from
3f52e80
to
1290b92
Compare
Burning1020
changed the title
|
It would be better to split three commits, a little confusing to review if mixed together |
vmm/sandbox/src/network/mod.rs
Outdated
| { | ||
| Ok(interface) => interface, | ||
| Err(e) => { | ||
| warn!("failed to parse network interface: {}, paas it", e); |
| @@ -266,6 +266,20 @@ impl NetworkInterface { | |||
| } | |||
| } | |||
| } | |||
| // find the pci device for unknown type interface, maybe it is a physical interface. | |||
There was a problem hiding this comment.
Is it certain that all physical interface with unknown type? Or is there any possibility that any other inferface with unknown type, will it cause any problem?
There was a problem hiding this comment.
Is it certain that all physical interface with unknown type? Or is there any possibility that any other inferface with unknown type, will it cause any problem?
We checked the netlink.LinkDeserialize() golang code, every type does have a correspond struct, but some of the structs do not be used, so we centralize them by Unknown type.
Burning1020
force-pushed
the
vmm-vfio
branch
6 times, most recently
from
247c514
to
5da472e
Compare
Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
| .map_err(|_| anyhow!("hvsock retry {}ms timeout", HVSOCK_RETRY_TIMEOUT_IN_MS))? | ||
| }) | ||
| .await | ||
| .map_err(|e| anyhow!("failed to spawn blocking task: {}", e))? |
There was a problem hiding this comment.
Why is the timeout removed when waiting?
There was a problem hiding this comment.
We have three kinds of "connectiing" method for unix socket, vsock and hvsock. All the methonds only handle the connecting, leaving the timeout be handled in the upper caller, e.g. new_ttrpc_client.
| let start_time = SystemTime::now(); | ||
| loop { | ||
| tokio::task::spawn_blocking(move || loop { |
There was a problem hiding this comment.
Why do we have to change it to async?
There was a problem hiding this comment.
We have called sync function UnixStream::connect(), thus it's better put it in a spawn_blocking
vmm/sandbox/src/network/mod.rs
Outdated
| { | ||
| Ok(interface) => interface, | ||
| Err(e) => { | ||
| warn!("failed to parse network interface: {}, pass it", e); |
Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
