added documentation for s3_endpoint (#78 / 213e9a8 and #92) #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Signed the CLA and submitted an issue (#92). Let me know if there's anything else ya need me to do. |
danielbodnar
changed the title
danielbodnar
added a commit
to danielbodnar/banzai-charts
that referenced
this pull request
May 7, 2019
ahma
pushed a commit
to banzaicloud/banzai-charts
that referenced
this pull request
May 8, 2019
orymate
approved these changes
May 8, 2019
simonkey007
pushed a commit
to simonkey007/logging-operator
that referenced
this pull request
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
I added additional documentation for the s3_endpoint variable and will be submitting another PR to the banzaicloud/banzai-charts.
Why?
I want to use Wasabi instead of Amazon, and noticed the feature existed but appeared undocumented.