-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove native-tls
feature
#1044
Conversation
8db9545
to
ac781ab
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
- Coverage 72.29% 72.29% -0.01%
==========================================
Files 65 65
Lines 4692 4688 -4
==========================================
- Hits 3392 3389 -3
+ Misses 1300 1299 -1
|
ac781ab
to
d9e70c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup!
d9e70c1
to
76b2a7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Thanks for fixing Clippy. I'll merge this after rebasing. |
Signed-off-by: kazk <kazk.dev@gmail.com>
76b2a7e
to
ba989c0
Compare
native-tls
feature exists becausekube
used to depend onreqwest
. It doesn't really make sense for us becauseopenssl
is required on all platforms anyway. It also doesn't work on macOS (#89 and #691), so the default was changed toopenssl-tls
since 0.71.0 (#863).This PR removes the feature as discussed in #863 (comment).
Closes #89
Closes #691