Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix codecov + tests #1305

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Try to fix codecov + tests #1305

merged 4 commits into from
Oct 9, 2023

Conversation

clux
Copy link
Member

@clux clux commented Oct 8, 2023

1. Trying again to stop codecov from posting status checks

Informational is what we want.

2. windows test ignore in client/auth/mod

https://github.com/kube-rs/kube/actions/runs/6443438740/job/17495479744 has started failing mysteriously on windows with a ParseTokenKey(Error("EOF while parsing a value", line: 2, column: 0)) on client/auth/mod:631 which is weird. this thing hasn't had changes in a year (so probably windows environment related for github ci).

3. add doc test job

we occasionally get outdated doc links being added, trying a doc job to see if it can help catch broken links
see output
some warnings in there atm, but those are warnings only

Trying again to stop codecov from posting status checks. Informational is what we want.
Second thing is a windows test ignore: https://github.com/kube-rs/kube/actions/runs/6443438740/job/17495479744 has started failing mysteriously on windows
with a `ParseTokenKey(Error("EOF while parsing a value", line: 2, column: 0))` on client/auth/mod:631 which is weird. this thing hasn't had changes in a year (so probably windows environment related for github ci).

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added the changelog-exclude changelog excluded prs label Oct 8, 2023
@clux clux added this to the 0.87.0 milestone Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #1305 (b1d5589) into main (7ef858d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1305   +/-   ##
=====================================
  Coverage   72.4%   72.4%           
=====================================
  Files         75      75           
  Lines       6341    6341           
=====================================
  Hits        4587    4587           
  Misses      1754    1754           
Files Coverage Δ
kube-client/src/client/auth/mod.rs 50.5% <ø> (ø)

clux added 3 commits October 8, 2023 22:52
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux marked this pull request as ready for review October 8, 2023 22:41
@clux clux enabled auto-merge (squash) October 9, 2023 10:32
@clux clux disabled auto-merge October 9, 2023 10:33
@clux clux merged commit 68ae55c into main Oct 9, 2023
18 checks passed
@clux clux deleted the test-fixes branch October 9, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant