Replace actix-web with axum #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clux
reviewed
Oct 31, 2021
clux
reviewed
Nov 1, 2021
Signed-off-by: Shane Sveller <shane@sveller.dev> Signed-off-by: Shane Sveller <shanesveller@gmail.com>
...as it's already omitted from tracing. #7 (comment) Signed-off-by: Shane Sveller <shanesveller@gmail.com>
#7 (review) Signed-off-by: Shane Sveller <shanesveller@gmail.com>
...and remove TryFrom due to inclusion in 2021 prelude https://doc.rust-lang.org/edition-guide/rust-2021/prelude.html Signed-off-by: Shane Sveller <shanesveller@gmail.com>
Signed-off-by: Shane Sveller <shanesveller@gmail.com>
Signed-off-by: Shane Sveller <shanesveller@gmail.com>
#7 (comment) Signed-off-by: Shane Sveller <shanesveller@gmail.com>
|
Sorry for the force-push, I missed my DCO on some of the additional commits. |
|
This is great. Thanks a lot! Quick comparison of compile times before and after:
pretty nice improvement for a small repo :-) |
clux
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if there is any desired format for commit message or other contributor guidance. Happy to address any feedback about the changes as well.