-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update documentation to include installation with in-cluster prometheus in openshift #1144
Open
mittal-ishaan
wants to merge
11
commits into
main
Choose a base branch
from
openshift-prometheus
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e5133f3
update documentation to include installation with in-cluster promethe…
mittal-ishaan 95f6682
add placeholder
mittal-ishaan c6f74a6
update on installation values file
mittal-ishaan 1f5bc83
update documentation to include installation with in-cluster promethe…
mittal-ishaan 228d41a
add placeholder
mittal-ishaan a51bff8
update on installation values file
mittal-ishaan 96fdc31
Merge branch 'openshift-prometheus' of https://github.com/kubecost/do…
mittal-ishaan 1e0551b
remove configuration details as they are moved to new values file
mittal-ishaan 274f065
nit fixes
mittal-ishaan 7b7e5a3
Apply suggestions from code review
mittal-ishaan 800ca8b
Merge branch 'main' into openshift-prometheus
mittal-ishaan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The drawback to doing this is that now this link will no longer be checked by the CI's link-checker. What happens if we someday decide to rename or delete
values-openshift.yaml
?Although referencing
develop
branch comes with drawbacks, I still think it's more valuable than putting<$VERSION>
here. @mittal-ishaan @chipzoller thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use develop. But we can also start with having versions. like
v2.5
and then update docs when every new minor or major version gets released.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasvn, the problem here with listing files from the
develop
branch is we put users in a precarious and potentially unsupported position when they install a versioned release but use a values file which doesn't correspond to that release. We really need to get away from that practice entirely when we're talking about our official docs. Rather than putting in a placeholder like<$VERSION>
we should make this the same as the version referenced by the docs. For example, if users are reading version 2.5 of our docs then any files that are associated with that release should be pointed to thev2.5
branch. This obviously means that any new files that get referenced are "released" in that branch.