Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downstream bug in IL #283

Merged
merged 1 commit into from
May 24, 2022
Merged

Conversation

JimmyYang20
Copy link

bug: after deleting dataset, the event of deleting job can be sent to LC.

Signed-off-by: JimmyYang20 yangjin39@huawei.com

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 17, 2022
bug: after deleting dataset, the event of deleting job can not be sent to LC.

Signed-off-by: JimmyYang20 <yangjin39@huawei.com>
@JimmyYang20 JimmyYang20 changed the title Fix downstrem bug in IL Fix downstraem bug in IL Mar 20, 2022
@JimmyYang20 JimmyYang20 changed the title Fix downstraem bug in IL Fix downstream bug in IL Mar 21, 2022
@jaypume
Copy link
Member

jaypume commented May 11, 2022

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2022
ds, err := c.client.Datasets(job.Namespace).Get(context.TODO(), dataName, metav1.GetOptions{})
if err != nil {
return fmt.Errorf("dataset(%s/%s) not found", job.Namespace, dataName)
klog.Errorf("not found job(name=%s/%s)'s dataset, error: %v", job.Kind, job.Name, err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no return here, maybe dsNodeName will be empty in the function below:

	if eventType == watch.Deleted {
		// delete jobs from all LCs
		nodes := sets.NewString(dsNodeName, trainNodeName, evalNodeName, deployNodeName)
		for node := range nodes {
			c.sendToEdgeFunc(node, eventType, job)
		}
		return nil
	}

dsNodeName in sets.NewString(dsNodeName, trainNodeName, evalNodeName, deployNodeName) maybe an empty string.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the func sendToEdgeFunc will handle the case where the node is empty.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@Poorunga
Copy link
Member

/lgtm

@jaypume
Copy link
Member

jaypume commented May 24, 2022

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypume

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2022
@kubeedge-bot kubeedge-bot merged commit cec574f into kubeedge:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants