Compatible with training-operator CRD. #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
requested review from
denverdino,
wsxiaozhang and
xiaozhouX
|
@cheyang @panpan0000 PTAL, thank you! |
cheyang
reviewed
Jan 16, 2024
Signed-off-by: Syulin7 <735122171@qq.com>
Syulin7
force-pushed
the
support_new_crd
branch
from
dbfeb42
to
feaedb2
Compare
|
@cheyang Thanks for the review! please take a look again. |
cheyang
reviewed
Jan 16, 2024
| @@ -44,6 +45,10 @@ func SubmitPytorchJob(namespace string, submitArgs *types.SubmitPyTorchJobArgs) | |||
| } | |||
| // the master is also considered as a worker | |||
| submitArgs.WorkerCount = submitArgs.WorkerCount - 1 | |||
|
|
|||
| compatible := CompatibleJobCRD(k8saccesser.PytorchCRDName, "runPolicy") | |||
There was a problem hiding this comment.
Could we add more explanatory comments to enhance maintainability?
cheyang
reviewed
Jan 16, 2024
| @@ -49,6 +51,10 @@ func SubmitTFJob(namespace string, submitArgs *types.SubmitTFJobArgs) (err error | |||
| if submitArgs.TFRuntime != nil { | |||
| tfjob_chart = util.GetChartsFolder() + "/" + submitArgs.TFRuntime.GetChartName() | |||
| } | |||
|
|
|||
cheyang
reviewed
Jan 16, 2024
| } | ||
|
|
||
| return compatible | ||
| } |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang, Syulin7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #966
Compatible with training-operator CRD.