Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile and release workflow #1128

Merged
merged 10 commits into from
Sep 12, 2024
Merged

Conversation

ChenYi015
Copy link
Collaborator

@ChenYi015 ChenYi015 commented Sep 9, 2024

What this PR does / why we need it:

  1. Add some useful targets to Makefile.
  2. Add github workflow for releasing arena. To release a new version of arena, a PR should be raised to the release branch e.g. release-0.9, then a check-release workflow will run to check whether the PR is valid (e.g. whether the VERSION has been modifed, whether the chart version and appVersion has been modified). After the PR is merged, a release workflow will be triggered to package the arena installer tarballs, then draft a release with the tarballs added as artifacts.
  3. Add integration test workflow for building Java SDK.
  4. Add linux/arm64, darwin/arm64 support to the arena installer tarballs.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
@ChenYi015
Copy link
Collaborator Author

/hold

Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
@ChenYi015
Copy link
Collaborator Author

/assign @Syulin7 @cheyang

@ChenYi015
Copy link
Collaborator Author

/hold cancel

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Sep 12, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f11dae2 into kubeflow:master Sep 12, 2024
3 of 4 checks passed
@ChenYi015 ChenYi015 deleted the dev branch September 12, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants