Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to sync cache due to status subresouce missed in tfjob CRD #1173

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ChenYi015
Copy link
Collaborator

@ChenYi015 ChenYi015 commented Oct 14, 2024

Purpose of this PR

Close #1174

Proposed changes:

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 82fd0ba into kubeflow:master Oct 14, 2024
5 checks passed
@ChenYi015 ChenYi015 deleted the fix/crd branch October 14, 2024 12:52
ChenYi015 added a commit to ChenYi015/arena that referenced this pull request Oct 14, 2024
kubeflow#1173)

Signed-off-by: Yi Chen <github@chenyicn.net>
(cherry picked from commit 82fd0ba)
@ChenYi015 ChenYi015 mentioned this pull request Oct 14, 2024
ChenYi015 added a commit that referenced this pull request Oct 14, 2024
* Bump github.com/prometheus/common from 0.59.1 to 0.60.0 (#1160)

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.59.1 to 0.60.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md)
- [Commits](prometheus/common@v0.59.1...v0.60.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit bf49baa)

* Bump golang.org/x/crypto from 0.27.0 to 0.28.0 (#1162)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.28.0.
- [Commits](golang/crypto@v0.27.0...v0.28.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 41fb18b)

* fix: keep arena installer after installing the binary (#1164)

* Release v0.10.0

Signed-off-by: Yi Chen <github@chenyicn.net>

* fix: keep arena installer after installing the binary

Signed-off-by: Yi Chen <github@chenyicn.net>

* Update tf-operator image

Signed-off-by: Yi Chen <github@chenyicn.net>

---------

Signed-off-by: Yi Chen <github@chenyicn.net>
(cherry picked from commit fdcfd18)

* fix: unsupported success policy when success policy is not specified (#1170)

Signed-off-by: Yi Chen <github@chenyicn.net>
(cherry picked from commit 45c8e1b)

* Migrate docker image to ACREE (#1171)

Signed-off-by: Yi Chen <github@chenyicn.net>
(cherry picked from commit b8af066)

* Bump mkdocs-material from 9.5.38 to 9.5.40 (#1166)

Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.38 to 9.5.40.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](squidfunk/mkdocs-material@9.5.38...9.5.40)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 522a0c6)

* Bump google.golang.org/protobuf from 1.34.2 to 1.35.1 (#1163)

Bumps google.golang.org/protobuf from 1.34.2 to 1.35.1.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit a1b7285)

* fix: failed to sync cache due to status subresouce missed in tfjob CRD (#1173)

Signed-off-by: Yi Chen <github@chenyicn.net>
(cherry picked from commit 82fd0ba)

* Release v0.10.1

Signed-off-by: Yi Chen <github@chenyicn.net>

---------

Signed-off-by: Yi Chen <github@chenyicn.net>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tfjob controller fail to sync cache
2 participants